From: Stefano Zacchiroli Date: Thu, 26 Dec 2002 15:48:36 +0000 (+0000) Subject: - bugfix: typo in XSL patching X-Git-Tag: v0_3_99~119 X-Git-Url: http://matita.cs.unibo.it/gitweb/?a=commitdiff_plain;h=baf3f42c5e7ac0f89ac57d0c93ecfb377dda1f30;p=helm.git - bugfix: typo in XSL patching - bugfix: fixed parameters passed to 'wget' command - moved some comment from .ml to .mli --- diff --git a/helm/http_getter/http_getter_common.ml b/helm/http_getter/http_getter_common.ml index 67d72f4f1..c076c2e70 100644 --- a/helm/http_getter/http_getter_common.ml +++ b/helm/http_getter/http_getter_common.ml @@ -65,7 +65,7 @@ let patch_xsl = Pcre.replace ~pat:(sprintf "%s\\s+href=\"" tag) ~templ:( - sprintf "%s href=\"%s/getxslt?uri=" Http_getter_env.my_own_url tag) + sprintf "%s href=\"%s/getxslt?uri=" tag Http_getter_env.my_own_url) line in let (patch_import, patch_include) = @@ -79,28 +79,21 @@ let patch_dtd line = sprintf "ENTITY $1 SYSTEM \"%s/getdtd?uri=" Http_getter_env.my_own_url) line -let pp_error = - sprintf "

Http Getter error: %s

" -let pp_internal_error = - sprintf "

Http Getter Internal error: %s

" -let pp_msg = sprintf "

%s

" +let pp_error s = + sprintf "

Http Getter error: %s

" s +let pp_internal_error s = + sprintf "

Http Getter Internal error: %s

" s +let pp_msg s = sprintf "

%s

" s +let null_pp s = s let mk_return_fun pp_fun contype msg outchan = Http_daemon.respond - ~body:(pp_fun msg) - ~headers:["Content-Type", contype] - outchan + ~body:(pp_fun msg) ~headers:["Content-Type", contype] outchan let return_html_error = mk_return_fun pp_error "text/html" let return_html_internal_error = mk_return_fun pp_internal_error "text/html" let return_html_msg = mk_return_fun pp_msg "text/html" -let return_xml_msg = mk_return_fun pp_msg "text/xml" - (** - @param fname name of the file to be sent - @param contype Content-Type header value - @param contenc Content-Enconding header value - @param patch_fun function used to patch file contents - @param outchan output channel over which sent file fname *) +let return_xml_msg = mk_return_fun null_pp "text/xml" let return_file ~fname ?contype ?contenc ?(patch_fun = fun x -> x) outchan = let headers = match (contype, contenc) with @@ -109,21 +102,21 @@ let return_file ~fname ?contype ?contenc ?(patch_fun = fun x -> x) outchan = | (None, Some e) -> [ "Content-Enconding", e ] | (None, None) -> [] in - Http_daemon.send_basic_headers outchan; + Http_daemon.send_basic_headers ~code:200 outchan; Http_daemon.send_headers headers outchan; Http_daemon.send_CRLF outchan; Http_getter_misc.iter_file (fun line -> output_string outchan (patch_fun line ^ "\n")) fname - (* return a bad request http response *) let return_400 body outchan = Http_daemon.respond_error ~code:400 ~body outchan let wget ?output url = let flags = - (match output with Some file -> ["-O " ^ file] | None -> []) @ [url] + (match output with Some file -> ["-O"; file] | None -> []) @ [url] in Shell.call - ~stdout:Shell.to_dev_null ~stderr:Shell.to_dev_null [Shell.cmd "wget" flags] + ~stdout:Shell.to_dev_null ~stderr:Shell.to_dev_null + [Shell.cmd "wget" flags] (* TODO gzip and gunzip create executables file, but umask seems to be correctly inherited from the shell .... boh *) diff --git a/helm/http_getter/http_getter_common.mli b/helm/http_getter/http_getter_common.mli index 323c71d21..63c37ea01 100644 --- a/helm/http_getter/http_getter_common.mli +++ b/helm/http_getter/http_getter_common.mli @@ -43,7 +43,14 @@ val return_html_error: string -> out_channel -> unit val return_html_internal_error: string -> out_channel -> unit val return_html_msg: string -> out_channel -> unit val return_xml_msg: string -> out_channel -> unit + (** return a bad request http response *) val return_400: string -> out_channel -> unit + (** + @param fname name of the file to be sent + @param contype Content-Type header value + @param contenc Content-Enconding header value + @param patch_fun function used to patch file contents + @param outchan output channel over which sent file fname *) val return_file: fname:string -> ?contype:string -> ?contenc:string -> ?patch_fun:(string -> string) ->