From: Paolo Marinelli Date: Fri, 14 Mar 2003 16:13:50 +0000 (+0000) Subject: Added some comments to the source code. X-Git-Tag: before_refactoring~116 X-Git-Url: http://matita.cs.unibo.it/gitweb/?a=commitdiff_plain;h=e4fed32b1519f436de9ca84c3c9c67e1530808b6;p=helm.git Added some comments to the source code. --- diff --git a/helm/DEVEL/mathml_editor/dictionary-test.xml b/helm/DEVEL/mathml_editor/dictionary-test.xml index 94190888d..3fcc05694 100644 --- a/helm/DEVEL/mathml_editor/dictionary-test.xml +++ b/helm/DEVEL/mathml_editor/dictionary-test.xml @@ -33,7 +33,7 @@ - + diff --git a/helm/DEVEL/mathml_editor/src/TPushParser.cc b/helm/DEVEL/mathml_editor/src/TPushParser.cc index 433b3fdec..7a8356f7d 100644 --- a/helm/DEVEL/mathml_editor/src/TPushParser.cc +++ b/helm/DEVEL/mathml_editor/src/TPushParser.cc @@ -214,7 +214,7 @@ TPushParser::do_end() } else { - logger.warning("closing brace ignored"); + logger.warning("ignored closing brace"); return false; } } @@ -290,7 +290,7 @@ TPushParser::do_shift() } else { - logger.warning("parser: math shift"); + logger.warning("not allowed here"); return false; } } @@ -336,14 +336,14 @@ bool TPushParser::do_eol() { //if (cursor.parent()) cursor.remove(); - logger.warning("token ignored"); + logger.warning("ignored token"); return false; } bool TPushParser::do_parameter(const std::string& p) { - logger.warning("token ignored"); + logger.warning("ignored token"); return false; } @@ -387,7 +387,7 @@ TPushParser::do_subscript() } else { - logger.warning("token ignored"); + logger.warning("ignored token"); return false; } } @@ -421,7 +421,7 @@ TPushParser::do_superscript() { if (parent["over"] == "1") { - logger.warning("token ignored: already over"); + logger.warning("already over"); return false; } else @@ -432,7 +432,7 @@ TPushParser::do_superscript() } else { - logger.warning("token ignored"); + logger.warning("ignored token"); return false; } } @@ -511,13 +511,13 @@ TPushParser::do_apostrophe() else { // is it an error? - logger.warning("parser: you have to type an identifier before ''"); + logger.warning("you have to insert an identifier before a ''"); return false; } } else { - logger.warning("token ignored: you have to be in a group"); + logger.warning("cursor has to be in a group"); return false; } } @@ -545,7 +545,7 @@ bool TPushParser::do_active(const std::string&) { // ??? space? - logger.warning("token ignorde"); + logger.warning("ignored token"); return false; } @@ -581,7 +581,7 @@ TPushParser::do_cr() else { // at the moment, \cr can only be used inside a table - logger.warning("token ignored: cr used outside a table"); + logger.warning("cr used outside a table"); return false; } } @@ -690,14 +690,14 @@ TPushParser::do_control(const std::string& name) else { // a macro with arguments or a rightOpen or leftOpen macro must be a group's child - logger.warning("token ignored: this macro should be in a group"); + logger.warning("ignored token: this macro should be in a group"); return false; } } break; case TDictionary::UNDEFINED: { - logger.warning("parser: using undefined macro " + name); + logger.warning("using undefined macro " + name); TNode m = doc.createC(name, nextId++); cursor.replace(m); advance(m); @@ -707,7 +707,7 @@ TPushParser::do_control(const std::string& name) default: { //assert(0); - logger.warning("token ignored"); + logger.warning("ignored token"); return false; } } @@ -783,9 +783,9 @@ TPushParser::drop_prev_script(bool special) // child has been removed yet. if (cursor.prev().isG() && !prev.hasId()) { - // in this case, the user has inserted the a sequence of '. - // Hence, we force a normal deleting, because the behavior must be the same - // for the two kind of deleting + // in this case, the user has inserted a sequence of '. + // Hence, we force a normal deletion, because the behavior must be the same + // for the two kind of deletion return drop_prev(false); } else return drop_prev(special); @@ -882,7 +882,7 @@ TPushParser::drop_prev_macro(bool special) // In this case, we do not have to push a frame in the stack, because we remove the // MACRO immediately, substituting it with the content of the phantom group. // We could remove the last child of the phantom group, but - // it's not clear if it's the correct behavior of the graphical deleting. + // it's not clear if it's the correct behavior of the graphical deletion. // At the moment, to give a standard behavior, we remove the last element. // With a special deletion, we do not remove it. assert(prev.first()); @@ -953,7 +953,7 @@ TPushParser::drop_prev_macro(bool special) // now, p is the correct value of pos, and we can push the frame. frames.push(Frame(entry, p)); - // To give a standard behavior to the graphical deleting, we remove the last + // To give a standard behavior to the graphical deletion, we remove the last // element of the macro. Since we are in a phantom group, we can invoke the // do_drop_phantom_group(special). return do_drop_phantom_group(special); @@ -981,7 +981,7 @@ TPushParser::drop_prev_macro(bool special) { // to type a table with rows and cells, the user had typed a // "{", and to exit from it, the user had inserted a "}". - // Since we are in a special deleting, we just idealy remove the "}" + // Since we are in a special deletion, we just idealy remove the "}" return ""; } else return do_drop_phantom_group(special); @@ -1030,7 +1030,7 @@ TPushParser::drop_prev_macro(bool special) std::string TPushParser::drop_prev(bool special) { - // if in this function, the prev of cursor does exist, also the parent and we want a graphical deleting. + // if in this function, the prev of cursor does exist, also the parent and we want a graphical deletion. assert(cursor.prev()); assert(cursor.parent()); @@ -1168,7 +1168,7 @@ TPushParser::do_drop_macro(bool special) assert(cursor.parent() && cursor.parent().isC()); TNode parent = cursor.parent(); - // this string is useful iff we have a special deleting + // this string is useful iff we have a special deletion. std::string macro_name = parent.nameC(); assert(!frames.empty()); @@ -1190,7 +1190,7 @@ TPushParser::do_drop_macro(bool special) if (special) return "\\" + macro_name; else { - // Since the macro had no children and this is a graphical deleting, we try + // Since the macro had no children and this is a graphical deletion, we try // to remove something else return do_drop(special); } @@ -1225,7 +1225,7 @@ TPushParser::do_drop_macro(bool special) assert(sequence_length); frame.pos = frame.pos - sequence_length - 1; - // since it's a graphical deleting, we have to remove the current preceding element. + // since it's a graphical deletion, we have to remove the current preceding element. // We don't invoke the drop_prev(), because a do_drop_phantom_group is more general. return do_drop_phantom_group(special); } @@ -1234,7 +1234,7 @@ TPushParser::do_drop_macro(bool special) { // the prev is not a delimited argument, so we have to try to remove it. // We "try", because the prev might be something that - // a simple delete cannot remove completely + // a simple deletion cannot remove completely return drop_prev(special); } } @@ -1282,7 +1282,7 @@ TPushParser::do_drop_groupId(bool special) else { rgreplace_father(); - // we have to re-start the process, because it' a graphical deleting + // we have to re-start the process, because it' a graphical deletion return do_drop(special); } } @@ -1392,7 +1392,7 @@ TPushParser::do_drop_phantom_group(bool special) assert(!frames.empty()); Frame& frame = frames.top(); - // this variable is useful in a special deleting + // this variable is useful in a special deletion std::string macro_name = gfather.nameC(); if (frame.entry.leftOpen && frame.entry.rightOpen) @@ -1428,7 +1428,7 @@ TPushParser::do_drop_phantom_group(bool special) if (special) return "\\" + macro_name; else { - // to give a standard behavior to the graphical deleting, we call the do_drop. + // to give a standard behavior to the graphical deletion, we call the do_drop. return do_drop(special); } } @@ -1449,7 +1449,7 @@ TPushParser::do_drop_phantom_group(bool special) if (special) return "\\" + macro_name; else { - // to give a standard behavior to the graphical deleting, we call the do_drop. + // to give a standard behavior to the graphical deletion, we call the do_drop. return do_drop(special); } @@ -1552,7 +1552,7 @@ TPushParser::do_drop_phantom_group(bool special) // a cell MUST be a row's child, which in turn is a table's child assert(gfather.parent() && gfather.parent().is("row") && gfather.parent().parent()); - // this variable is useful to handle the special deleting + // this variable is useful to handle the special deletion std::string table_name = gfather.parent().parent().nameC(); TNode row = gfather.parent(); @@ -1604,8 +1604,8 @@ TPushParser::do_drop_phantom_group(bool special) assert(last_cell.first().isG() && !last_cell.first().hasId()); last_cell.first().append(cursor); // Since cells and rows are separated by spaces and CRs - // (and the user can see this spaces and CRs), a special deleting - // is equivalent to a normal deleting + // (and the user can see this spaces and CRs), a special deletion + // is equivalent to a normal deletion return ""; } } // end of if (!prev_cell) @@ -1637,13 +1637,13 @@ TPushParser::do_drop_phantom_group(bool special) { // in this case we ignore the user's will of deleting // but we could also decide to remove the math mode. - logger.warning("Parser: nothing to delete"); + logger.warning("nothing to delete"); return ""; } else { // cursor's grand father is undefined - logger.error("parser: TML tree is in a unknown state"); + logger.error("TML tree is in an unknown state"); return ""; } } // end of the else of the if (prev) @@ -1771,7 +1771,7 @@ TPushParser::push(const TToken& token) // - ignore the token, and wait for the correct delimiter // - ignore the token, wait for the correct delimiter and emit an error // At the moment, we implement the second possibily - logger.warning("parser: it's not the correct delimiter...you have to type " + frame.entry.pattern[frame.pos + 1].value); + logger.warning("it's not the correct delimiter...you have to type '" + frame.entry.pattern[frame.pos + 1].value + "'"); } else { @@ -1826,7 +1826,7 @@ TPushParser::push(const TToken& token) else { // There is a mismatch. Emit an error and ignore the token? - logger.warning("parser: token ignored: " + token.value); + logger.warning("ignored token: " + token.value); } } else diff --git a/helm/DEVEL/mathml_editor/test/editor.cc b/helm/DEVEL/mathml_editor/test/editor.cc index 00aa28eb9..6f9175f94 100644 --- a/helm/DEVEL/mathml_editor/test/editor.cc +++ b/helm/DEVEL/mathml_editor/test/editor.cc @@ -26,9 +26,6 @@ #include "dom.hh" #include "TPushParser.hh" -#include "LPushLexer.hh" - -#include "TPushLexer.hh" #include "ILPushLexer.hh" #include "TDictionary.hh" #include "CLoggerConsole.hh" @@ -38,8 +35,6 @@ #include "guiGTK.h" -typedef ILPushLexer MyPushLexer; - extern void *parseMathMLFile(char *); struct Context @@ -47,7 +42,7 @@ struct Context /* Context(const std::string& s, TPushLexer& l, TPushParser& p) : buffer(s), i(0), lexer(l), parser(p) { }; */ - Context(const std::string& s, MyPushLexer& l, TPushParser& p, DOMX::XSLTStylesheet& ts) + Context(const std::string& s, APushLexer& l, TPushParser& p, DOMX::XSLTStylesheet& ts) : buffer(s), i(0), lexer(l), parser(p), texStyle(ts) { }; void send(void) @@ -57,8 +52,7 @@ struct Context std::string buffer; unsigned i; - //TPushLexer& lexer; - MyPushLexer& lexer; + APushLexer& lexer; TPushParser& parser; DOMX::XSLTStylesheet& texStyle; }; @@ -170,7 +164,7 @@ main(int argc, char* argv[]) CMathMLFactoryXSLT factory(logger, mmlStyle); TPushParser parser(logger, factory, dictionary); - MyPushLexer lexer(logger, parser, dictionary); + ILPushLexer lexer(logger, parser, dictionary); #if 0 lexer.push('$'); diff --git a/helm/DEVEL/mathml_editor/xsl/tml-mmlp.xsl b/helm/DEVEL/mathml_editor/xsl/tml-mmlp.xsl index 7b1ad7cb3..b0adffdc0 100644 --- a/helm/DEVEL/mathml_editor/xsl/tml-mmlp.xsl +++ b/helm/DEVEL/mathml_editor/xsl/tml-mmlp.xsl @@ -1135,8 +1135,4 @@ - - - -