From 352aa2e42b054c1ecd80d5767c561758f210a3a7 Mon Sep 17 00:00:00 2001
From: Enrico Tassi <enrico.tassi@inria.fr>
Date: Mon, 7 Apr 2008 10:54:11 +0000
Subject: [PATCH] fixed bug in translating Fix, recno was not properly computed

---
 .../components/ng_kernel/oCic2NCic.ml         | 47 ++++++++++---------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/helm/software/components/ng_kernel/oCic2NCic.ml b/helm/software/components/ng_kernel/oCic2NCic.ml
index 2244c12f8..5bb6b93e2 100644
--- a/helm/software/components/ng_kernel/oCic2NCic.ml
+++ b/helm/software/components/ng_kernel/oCic2NCic.ml
@@ -1,4 +1,4 @@
-let convert_term = Obj.magic;;
+module Ref = NReference
 
 let cn_to_s = function
   | Cic.Anonymous -> "_"
@@ -7,7 +7,7 @@ let cn_to_s = function
 
 type ctx = 
   | Ce of NCic.hypothesis 
-  | Fix of NReference.reference * string * NCic.term
+  | Fix of Ref.reference * string * NCic.term
 
 let splat mk_pi ctx t =
   List.fold_left
@@ -76,7 +76,7 @@ let convert_term uri t =
           List.fold_right 
             (fun (name,ty,_) (ctx, fixpoints, tys, idx) -> 
               let ty, fixpoints_ty = aux octx ctx n_fix uri ty in
-              let r = NReference.reference_of_ouri buri(NReference.CoFix idx) in
+              let r = Ref.reference_of_ouri buri(Ref.CoFix idx) in
               Fix (r,name,ty) :: ctx, fixpoints_ty @ fixpoints,ty::tys,idx+1)
             fl ([], [], [], 0)
         in
@@ -101,7 +101,7 @@ let convert_term uri t =
             NCic.Fixpoint (false, fl, (`Generated, `Definition)) 
         in
         splat_args ctx 
-         (NCic.Const (NReference.reference_of_ouri buri (NReference.CoFix k)))
+         (NCic.Const (Ref.reference_of_ouri buri (Ref.CoFix k)))
          n_fix,
         fixpoints @ [obj]
     | Cic.Fix (k, fl) ->
@@ -110,19 +110,23 @@ let convert_term uri t =
            (UriManager.buri_of_uri uri^"/"^
             UriManager.name_of_uri uri ^ string_of_int (List.length ctx)^".con")
         in
-        let rno = ref 0 in
-        let bctx, fixpoints_tys, tys, _ = 
+        let bad_bctx, fixpoints_tys, tys, _ = 
           List.fold_right 
             (fun (name,recno,ty,_) (bctx, fixpoints, tys, idx) -> 
               let ty, fixpoints_ty = aux octx ctx n_fix uri ty in
-              if idx = k then rno := recno;
-              let r = 
-                NReference.reference_of_ouri buri (NReference.Fix (idx,recno)) 
+              let r =  (* recno is dummy here, must be lifted by the ctx len *)
+                Ref.reference_of_ouri buri (Ref.Fix (idx,recno)) 
               in
               Fix (r,name,ty) :: bctx, fixpoints_ty@fixpoints,ty::tys,idx+1)
             fl ([], [], [], 0)
         in
-        let bctx = bctx @ ctx in
+        let _, free, _ = context_tassonomy (bad_bctx @ ctx) in
+        let bctx = 
+          List.map (function 
+            | Fix (Ref.Ref (_,_,Ref.Fix (idx, recno)),name, ty) ->
+              Fix (Ref.reference_of_ouri buri(Ref.Fix (idx,recno+free)),name,ty)
+            | _ -> assert false) bad_bctx @ ctx
+        in
         let n_fl = List.length fl in
         let boctx,_ =
          List.fold_left
@@ -130,15 +134,16 @@ let convert_term uri t =
              (Some (Cic.Name n,(Cic.Decl (CicSubstitution.lift len ty)))::types,
               len+1)) (octx,0) fl
         in
-        let fl, fixpoints =
+        let rno_k = ref 0 in
+        let fl, fixpoints,_ =
           List.fold_right2 
-            (fun (name,rno,_,bo) ty (l,fixpoints) -> 
+            (fun (name,rno,_,bo) ty (l,fixpoints,idx) -> 
                let bo, fixpoints_bo = aux boctx bctx n_fl buri bo in
-               let _, free, _ = context_tassonomy bctx in
                let rno = rno + free in
+               if idx = k then rno_k := rno;
                (([],name,rno,splat true ctx ty, splat false ctx bo)::l),
-               fixpoints_bo @ fixpoints)
-            fl tys ([],fixpoints_tys)
+               fixpoints_bo @ fixpoints,idx+1)
+            fl tys ([],fixpoints_tys,0)
         in
         let obj = 
           NUri.nuri_of_ouri buri,0,[],[],
@@ -146,7 +151,7 @@ let convert_term uri t =
         in
         splat_args ctx
           (NCic.Const 
-            (NReference.reference_of_ouri buri (NReference.Fix (k,!rno))))
+            (Ref.reference_of_ouri buri (Ref.Fix (k,!rno_k))))
           n_fix,
         fixpoints @ [obj]
     | Cic.Rel n ->
@@ -198,14 +203,14 @@ let convert_term uri t =
         | (NCic.Appl l1)::l2 -> NCic.Appl (l1@l2), fixpoints
         | _ -> NCic.Appl l, fixpoints)
     | Cic.Const (curi, _) -> 
-        NCic.Const (NReference.reference_of_ouri curi NReference.Def),[]
+        NCic.Const (Ref.reference_of_ouri curi Ref.Def),[]
     | Cic.MutInd (curi, tyno, _) -> 
-        NCic.Const (NReference.reference_of_ouri curi (NReference.Ind tyno)),[]
+        NCic.Const (Ref.reference_of_ouri curi (Ref.Ind tyno)),[]
     | Cic.MutConstruct (curi, tyno, consno, _) -> 
-        NCic.Const (NReference.reference_of_ouri curi 
-        (NReference.Con (tyno,consno))),[]
+        NCic.Const (Ref.reference_of_ouri curi 
+        (Ref.Con (tyno,consno))),[]
     | Cic.MutCase (curi, tyno, oty, t, branches) ->
-        let r = NReference.reference_of_ouri curi (NReference.Ind tyno) in
+        let r = Ref.reference_of_ouri curi (Ref.Ind tyno) in
         let oty, fixpoints_oty = aux octx ctx n_fix uri oty in
         let t, fixpoints_t = aux octx ctx n_fix uri t in
         let branches, fixpoints =
-- 
2.39.2